Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prettierx] -- align-object-properties option #35

Merged
merged 1 commit into from
Jan 14, 2019

Conversation

brody4hire
Copy link
Collaborator

feature ported from prettier-miscellaneous (arijs#7 & arijs#8), with adaptations by @brodybits

continuation of PR #4, not applied with any of the JSON parsers as verified by json test

feature ported from prettier-miscellaneous
(arijs#7 & arijs#8)

with adaptations by @brodybits
(Christopher J. Brody <[email protected]>), including:
* JavaScript tests in es test subdirectory
* not applied with any of the JSON parsers, as verified by json test
  (not applied in case parser matches /json/ pattern)
* --align-object-properties option config & docs adapted
  (copy-pasted) into newer prettier/prettierx project structure
* const shouldBreak hack updated (and reformatted), can now deal
  with an object that is partially but not completely defined
  on the first line, as verified by an additional test object
* extra comment(s) & spacing
* additional testing to ensure that it does not get unwanted padding
  in case an object is on a single line
* hack with fix for object partially but not completely defined
  on the first line, with additional test to verify
* test coverage on babel, flow, and typescript parsers
* test with shorthand object member
* tests_integration updates
* some other added tests
* lint fixes

Co-authored-by: Christopher J. Brody <[email protected]>
Co-authored-by: Joseph Frazier <[email protected]>
Co-authored-by: Rafael Hengles <[email protected]>
Co-authored-by: Ika <[email protected]>
Co-authored-by: Lucas Azzola <[email protected]>
@brody4hire brody4hire force-pushed the prettierx-align-object-properties branch from 1674f7f to 4050865 Compare January 14, 2019 16:37
@brody4hire brody4hire merged commit cd79814 into dev Jan 14, 2019
@brody4hire brody4hire deleted the prettierx-align-object-properties branch January 14, 2019 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant