ci: use go 1.18 for tests as well #45
Conversation
|
@dim please, don't merge this one unless all tests pass - looks like we'll have problems with Go 1.17, need to address that separately. |
|
And... 🥁 It fails, for Go 1.18 as well. Will look in ~1h. |
|
Nope, I just forgot to configure KAFKA_ADDRS :) Fails locally as well. |
|
Figured out, that it works for sarama v1.32.0, but fails on v1.34.1 (UPD: fails right on next version - v1.33.0). Will check what change there. v1.32.0 retracted due to IBM/sarama#2150 |
| @@ -3,7 +3,7 @@ module github.com/bsm/bps/kafka | |||
| go 1.17 | |||
|
|
|||
| require ( | |||
| github.com/Shopify/sarama v1.34.1 | |||
| github.com/Shopify/sarama v1.32.0 | |||
There was a problem hiding this comment.
@dim I failed to do this in a reasonable amount of time, so "reverted" bumping the sarama lib.
It's OK to release as is (tests work etc), but this better be addressed at some point (v1.32.0 is "deprecated" 'cause it is prone to hang, though it's the only version that works with BPS tests).
No description provided.