-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Automates the process of running development environment #71
base: main
Are you sure you want to change the base?
Conversation
cd backend | ||
|
||
## install the backend dependencies | ||
echo "installing backend dependencies..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setup script should do the following -
- Installing dependencies
- Starting docker container
- Migrations and Seeding database
dev-env.sh
Outdated
cd backend | ||
|
||
## Run migration | ||
npm run migrate:dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dev script should just start the server and docker container at both frontend and backend.
…r development workflow
@Bhavik-ag There's a minute issue which I would like to discuss, on executing dev-env.sh file since we are running backend server in background (detached from the terminal) it causes the port 3333 remains in use even though the terminal has been killed due to which devs will have to either reopen the editor or manually close the port if they want to rerun the server. |
One possible solution would be to create a Cleanup function which will close the port whenever the terminal got closed. Let me know if this required. |
dev-env.sh
Outdated
cd ../frontend | ||
|
||
## start the frontend development server | ||
npm run dev & gnome-terminal -- npm run dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here npm run dev
is executed two times which cause the frontend server to start on both port 3000 and 3001.
@prajjwalkapoor Do you have any idea on the mentioned issue by @Pratik2026? |
Overview
This PR does the following: It introduces the Automation for the setup and running development environment server to streamline the development workflow.
Essential Checklist