Convert project to glide. #419
Conversation
jrick
force-pushed
the
glide
branch
22 times, most recently
from
89684bb to
fece438
Compare
|
Once this is in and btcd is converted to use glide as well, I would like to switch away from our btcsuite package paths back to the upstream ones. We can still maintain forked repos as a backup in case they disappear, but there is no reason to keep rewriting the import paths when we maintain control over the versions in the vendor directory. This should be done after btcd also is converted to glide since we don't want to import the same package multiple times with different names, as some of these dependencies are shared in btcd and btcwallet code. |
|
Could you maybe point out in the readme that go commands that do not recurse (go build/install without the ./...) work as normal after the glide install so there is no need for the glide novendor in those cases. |
|
Other than that doc request this looks good to me and works as expected on Linux and BItrig. |
|
sure, i'll update the readme to include both instructions Since those instructions are the same for both first time installs and updates, i'll try to merge them into a single place too. |
|
Do I need to test this on OSX as well? |
|
Unlikely to be an issue but it wouldn't hurt. |
jrick
force-pushed
the
glide
branch
4 times, most recently
from
ecfe621 to
0b9c460
Compare
|
I tested and as expected, OSX was fine. And new instructions look good. Not sure if anyone else wanted to chime in but OK from me. |
|
|
||
| - **Glide** | ||
|
|
||
| Glide is used to manage project dependencies and provide reproducable builds. |
jrick
force-pushed
the
glide
branch
2 times, most recently
from
784cfa1 to
63170f3
Compare
|
It appears that everything has been addressed. OK |
In btcsuite#419 (comment) I mentioned that btcwallet should wait until btcd also switches back to upstream package paths so that duplicate packages are not included in and bloat the btcwallet binary. Even while btcd has not yet switched to the upstream flags package, this change can still be made now since it is only used by btcd's main package, which is not included in btcwallet.
In btcsuite#419 (comment) I mentioned that btcwallet should wait until btcd also switches back to upstream package paths so that duplicate packages are not included in and bloat the btcwallet binary. Even while btcd has not yet switched to the upstream flags package, this change can still be made now since it is only used by btcd's main package, which is not included in btcwallet.
This prevents future calls to CreateNewWallet from erroring due to the database file existing. Fixes btcsuite#418.
Fixes #399.