fix: fix a bug cannot read href attribute in use tags #499
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#392
Description
Updated the attribute checking logic in
ensureSVGSymbols
to checkhref
first, then fall back toxlink:href
Motivation and Context
The
ensureSVGSymbols
function was only checking the deprecatedxlink:href
attribute, causing some SVG assets to fail rendering. The function should check bothhref
andxlink:href
attributes to properly handle all SVG use cases.xlink:href
attribute is deprecated in SVG 2href
attributeTypes of changes
Self Check before Merge