Fix scoping of variables declared in for loops. #233
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue encountered when compiling:
Buble incorrectly threw an error due to the 'i' in 'i++' being
incorrectly identified as a constant.
This commits makes it so for, for in and for of loops have their
own scope.
The way the variable declarations are handled to calculate
shouldRewriteAsFunction
is not ideal. It only got the bare minimum changes to pass the existing tests, so current limitations still apply.