Regenerate lockfile and pin types node #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-sachs
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #526.
This follows the advice specified in npm/cli#6301 for regenerating a package-lock.json file by removing node_modules and package-lock.json.
It appears there is an open issue where resolved and integrity fields are removed at times when the above steps are not followed.
This also pins
@types/nodeto all patch versions as upgrading the major/minor version causes issues in our TypeScript compatibility test since@types/nodedropped support for v4.1 and Protobuf-ES still supports it.Note that while this fixes the file with this PR, we cannot guarantee that this won't occur again due to the open issue with npm.