Reduce the memory overhead of Bugsnag when session tracking isn't enabled #606
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This PR requires the 'concurrent' gem only when it's needed, to help reduce the memory overhead of Bugsnag when session tracking isn't enabled (by ~4 MiB)
The shared SessionTracker instance is created on demand, so if an application doesn't use session tracking the 'concurrent' gem isn't required at all
This did have one drawback though — moving the require from the top level to the initialize method meant that the overhead from the concurrent gem was shifted into the first request, as that's where the first session will start. This had quite a big impact on response time (from ~10ms to ~70ms locally) so we now create the session tracker upfront. We do this after configuration has run so that we can avoid creating it if session tracking is disabled
Tests
The existing test suite should confirm this works
I've also manually tested that the SessionTracker isn't initialized when sessions are disabled (
config.auto_capture_sessions = false
)Linked issues
Fixes #536
Review
For the submitter, initial self-review:
For the pull request reviewer(s), this changeset has been reviewed for: