Add Maze Runner tests for 'on error' callbacks #609
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This PR adds Maze Runner tests for the new on error callbacks, added in #608
For the plain Ruby tests, they are duplicates of the existing tests for
before_notify_callbacks
. For Rails, they use a different structure because 'on error' callbacks should be added in theconfigure
block, so they use a new environment variable to add/not add themReview
For the submitter, initial self-review:
For the pull request reviewer(s), this changeset has been reviewed for: