Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Maze Runner tests for 'on error' callbacks #609

Merged
merged 2 commits into from
Jul 22, 2020

Conversation

imjoehaines
Copy link
Contributor

@imjoehaines imjoehaines commented Jul 20, 2020

Goal

This PR adds Maze Runner tests for the new on error callbacks, added in #608

For the plain Ruby tests, they are duplicates of the existing tests for before_notify_callbacks. For Rails, they use a different structure because 'on error' callbacks should be added in the configure block, so they use a new environment variable to add/not add them

Review

For the submitter, initial self-review:

  • Commented on code changes inline explain the reasoning behind the approach
  • Reviewed the test cases added for completeness and possible points for discussion
  • A changelog entry was added for the goal of this pull request
  • Check the scope of the changeset - is everything in the diff required for the pull request?
  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@imjoehaines imjoehaines force-pushed the on-error-callbacks-maze-runner-tests branch from 5d01452 to a943fc4 Compare July 22, 2020 12:57
Base automatically changed from on-error-callbacks to next July 22, 2020 13:35
@imjoehaines imjoehaines marked this pull request as ready for review July 22, 2020 13:36
@imjoehaines imjoehaines requested a review from Cawllec July 22, 2020 13:36
Copy link
Contributor

@Cawllec Cawllec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@imjoehaines imjoehaines merged commit f81c855 into next Jul 22, 2020
@imjoehaines imjoehaines deleted the on-error-callbacks-maze-runner-tests branch July 22, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants