Loosen rails version constraint in v5 & v6 fixtures #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattrali
approved these changes
Mar 26, 2021
imjoehaines
force-pushed
the
include-connection-id-in-breadcrumbs
branch
2 times, most recently
from
9266668 to
c2eab54
Compare
This was inadvertently stopping us from testing on the latest v5/v6 versions as we were locked to 5.0.x/6.0.x
imjoehaines
force-pushed
the
loosen-rails-version-constraint
branch
from
4804979 to
d364484
Compare
Rails 5.2 removed this method - we don't need it for anything so can remove the call without further changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Loosens the version constraint for rails 5 & 6 fixtures from
~> x.0.0to~> x. This was inadvertently stopping us from testing on the latest v5/v6 versions as we were locked to 5.0.x/6.0.x — for example, we weren't test against Rails 6.1Testing
Covered by CI, requires #655 to pass