Add support for Sidekiq 7 #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidekiq 7 has a new internal structure and middleware is now expected to include a module, depending on client vs server middleware. See: https://github.com/sidekiq/sidekiq/blob/main/docs/middleware.md
imjoehaines
force-pushed
the
add_sidekiq_7_support
branch
from
d662fff to
63048a5
Compare
imjoehaines
approved these changes
Jul 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sidekiq 7 has a new internal structure and middleware is now expected to include a module, depending on client vs server middleware. See: https://github.com/sidekiq/sidekiq/blob/main/docs/middleware.md
Goal
Support for Sidekiq 7, which has some new internals, including a slightly different middleware API. While we don't currently any of the things offered by the new API, this will make sure we don't break on accident.
Design
Only include the new middleware module if it's been defined, which will only happen for Sidekiq 7+.