Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links and missing sections in READMEs #4848

Merged
merged 6 commits into from
May 4, 2023

Conversation

etorreborre
Copy link
Member

This PR fixes some broken links in the ockam crate README since all the documentation has now moved over to docs.ockam.io.

The PR also adds some missing badges and sections (usage, licence) for some of the other READMEs.

and refer to the documentation website instead
add missing badges, usage, licence where necessary
@etorreborre etorreborre requested a review from a team as a code owner May 3, 2023 08:50
Copy link
Member

@adrianbenavides adrianbenavides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a small comment on the ockam_command readme

implementations/rust/ockam/ockam_command/README.md Outdated Show resolved Hide resolved
@etorreborre etorreborre force-pushed the etorreborre/doc/crates-doc branch from 1898372 to 3ffd1a2 Compare May 3, 2023 11:06
@etorreborre etorreborre marked this pull request as draft May 3, 2023 11:09
@etorreborre etorreborre force-pushed the etorreborre/doc/crates-doc branch from 3ffd1a2 to 1474d54 Compare May 3, 2023 12:54
@etorreborre etorreborre force-pushed the etorreborre/doc/crates-doc branch 2 times, most recently from 29a4a14 to b962c36 Compare May 3, 2023 13:43
@etorreborre etorreborre force-pushed the etorreborre/doc/crates-doc branch from b962c36 to 4854028 Compare May 3, 2023 16:28
@metaclips metaclips force-pushed the etorreborre/doc/crates-doc branch from d1a8d20 to 54ca9f6 Compare May 4, 2023 00:19
@etorreborre etorreborre marked this pull request as ready for review May 4, 2023 08:01
@etorreborre etorreborre enabled auto-merge May 4, 2023 08:01
@adrianbenavides adrianbenavides self-requested a review May 4, 2023 13:30
@etorreborre etorreborre added this pull request to the merge queue May 4, 2023
Merged via the queue into develop with commit 9eadf7f May 4, 2023
@etorreborre etorreborre deleted the etorreborre/doc/crates-doc branch May 4, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants