Allow junits_dir to match hidden files and dirs #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby's Dir.Glob will not match on Unix-like hidden files by default. Since build artifacts can be uploaded and downloaded from paths containing hidden directories, the junit plugin should match on hidden files and directories as well.
|
Hi @cursande! Sorry for the long delay! 😅 This looks good, thanks for your contributions! 🙏🏻 |
|
No worries @pzeballos 😄 though looks like the assertion in the test I originally wrote needs to be updated due to more recent mainline changes |
|
Are you able on doing those changes @cursande? This time will be faster 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 👋
Had a build pipeline that involved uploading files from directories nested within a hidden directory.
The artifact path is able to pick up hidden files and folders on upload and download, so I think the plugin should follow the same behaviour.
Hope everyone at buildkite is doing well.