Test summary #174
Merged
Test summary #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juandiegopalomino
added a commit
to juandiegopalomino/junit-annotate-local-buildkite-plugin
that referenced
this pull request
Oct 18, 2022
…_summary_issue_136 Test summary
juandiegopalomino
added a commit
to juandiegopalomino/junit-annotate-local-buildkite-plugin
that referenced
this pull request
Oct 18, 2022
* Merge pull request buildkite-plugins#166 from buildkite-plugins/renovate/ruby-3.1-alpine Update ruby:3.1-alpine Docker digest to c5acbb8 * Merge pull request buildkite-plugins#173 from buildkite-plugins/toote_test_revamp Test revamp & dependency update * Merge pull request buildkite-plugins#174 from buildkite-plugins/toote_summary_issue_136 Test summary Co-authored-by: Matías Bellone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has several related changes:
always-annotateto create the annotation even if no failures were found (closes feature request: mode to post number of tests successful when all are #136)I also changed the flow of the hook to avoid a lot of code duplication and complicated conditional paths.
As I modified the output of the ruby code, I revamped the rake tests as well checking stdout and stderr separately