Fix error when hook cannot be run due to missing interpreter #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passing the interpreter as the string value for the hook name, and is then printing an empty `%q` for the interpreter value. There is an addition of the `hookName` passed as a string to the `logMissingHookInfo` function. This value is passed from the `runWrappedShellScriptHook` function on [534](https://github.com/buildkite/agent/blob/65ed6aaf3dd3e50f88dee3fbd27714120e558965/internal/job/executor.go#L534).
mcncl
changed the title
mcncl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a missing value in the formatted string for the error, it is passing the interpreter as the string value for the hook name, and is then printing an empty
%qfor the interpreter value.Changes
There is an addition of the
hookNamepassed as a string to thelogMissingHookInfofunction. This value is passed from therunWrappedShellScriptHookfunction on 534.Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)