Added Timeout as parameter so it can be passed from stack parameters. #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen using the template. Default value is PT5M
|
Thanks @RexChenjq! Perhaps |
lox
reviewed
Sep 4, 2018
templates/buildkite-elastic.yml
Outdated
| @@ -641,7 +647,7 @@ Resources: | |||
|
|
|||
| CreationPolicy: | |||
| ResourceSignal: | |||
| Timeout: PT5M | |||
| Timeout: { !Ref Timeout } | |||
There was a problem hiding this comment.
This should just be !Ref Timeout I believe!
|
@lox Yep good idea. I have renamed the parameter to InstanceCreationTimeout and fixed the syntax of !Ref by using { Ref } to maintain the consistency of the style. Thanks! |
|
Thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the template, timeout value for autoscaling group->creation policy can now be customised.
Default value is PT5M which sometimes blocks the deployment as the job it is running is too heavy and 5mins is not able to finish the ASG setup.