Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get SSM parameter as raw text #625

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

jradtilbrook
Copy link
Contributor

This is a carry on from #624 to fix the newly introduced support for SSM parameter for the agent token.

Without the change, the get-parameter command returns the value as it appeared in the default json output which includes quotes.
Eg: "token is here".

This was then double quoted by the script and when the EC2 instance boots up it sends the token to the API as ""token is here"" which is invalid.

With this change the quotes are removed from the get-parameter command so there is only one level of quotes

@jradtilbrook
Copy link
Contributor Author

@lox What do you think to this fix?

@lox lox merged commit aab4ad9 into buildkite:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants