Disentangle matrix into 3 types
#128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angusfretwell
changed the title
matrix into 3 typesmatrix into 3 types
This was referenced Jan 15, 2025
|
Hey @thejcannon, thanks for the contribution 😊. This is looking great so far ~ it looks like the tests aren't passing in CI for this branch (I've replicated this failure locally as well). Are you able to have a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having poked through the docs and trying to upload several pipelines, it really seems like there's 3
matrixtypes:setuplist of elements with adjustments (which are strings)setupmapping with adjustments (which are objects)So, disentangled the definitions to reflect the 3 types