Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go from 1.22 to 1.23 #307

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Bump Go from 1.22 to 1.23 #307

merged 1 commit into from
Oct 7, 2024

Conversation

buildpack-bot
Copy link
Member

Bumps Go from 1.22 to 1.23 and update Go modules used by the project. See the commit for details on what modules were updated.

Release Notes

@buildpack-bot buildpack-bot requested a review from a team as a code owner September 30, 2024 02:48
@buildpack-bot buildpack-bot added semver:minor A change requiring a minor version bump type:task A general task labels Sep 30, 2024
@buildpack-bot buildpack-bot requested a review from a team as a code owner September 30, 2024 02:48
Bumps Go from 1.22 to 1.23 and update Go modules used by the project. See the commit for details on what modules were updated.

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jkutner jkutner merged commit 3013147 into main Oct 7, 2024
4 checks passed
@jkutner jkutner deleted the update/go branch October 7, 2024 09:59
@edmorley
Copy link
Collaborator

edmorley commented Nov 5, 2024

This caused image builds to fail, eg:
https://github.com/buildpacks/github-actions/actions/runs/11669505648/job/32491606433#step:5:131

To fix, we'll need something similar to the PR that was opened last time this happened:
#307

It would be great to also add CI coverage of the Dockerfile build to prevent this happening a third time :-)

xref:
https://cloud-native.slack.com/archives/C032YE21V1T/p1730810769628839

@edmorley edmorley mentioned this pull request Nov 5, 2024
@jjbustamante
Copy link
Member

We should add some documentation around this, before bumping the go version, update the Dockerfile to avoid breaking the registry

@edmorley
Copy link
Collaborator

edmorley commented Nov 5, 2024

IMO CI coverage would be preferable to documentation :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants