-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Support multiple, ordered, nullable thumbnail requests.
I've basically just added a helper method that calls thumbnail() recursively for you. It seems like it eliminates some of the especially confusing nested thumbnail logic. Unfortunately it requires @SuppressWarnings("unchecked") whever it's used because it uses varags with a parameterized type (RequestBuilder). I can't currently use @SafeVarargs because that requires a final method. I can't make the method final without preventing mocking in tests (minor) and breaking the generated API (major). By splitting out a separate base class for RequestBuilder I actually probably can fix this in the future, but that's a pretty substantial change that I don't want to make right now. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=171694145
- Loading branch information
Showing
2 changed files
with
87 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters