Add @RequiresPermission to NotificationTarget

bumptech · Jul 26, 2023 · d6d1308 · d6d1308
1 parent fd96de2
commit d6d1308
Showing 1 changed file with 21 additions and 0 deletions.
diff --git a/library/src/main/java/com/bumptech/glide/request/target/NotificationTarget.java b/library/src/main/java/com/bumptech/glide/request/target/NotificationTarget.java
@@ -39,6 +39,9 @@ public class NotificationTarget extends CustomTarget<Bitmap> {
    * @param notification The Notification object that we want to update.
    * @param notificationId The notificationId of the Notification that we want to load the Bitmap.
    */
+  @SuppressLint("InlinedApi")
+  // Alert users of Glide to have this permission.
+  @RequiresPermission(Manifest.permission.POST_NOTIFICATIONS)
   public NotificationTarget(
       Context context,
       int viewId,
@@ -61,6 +64,9 @@ public NotificationTarget(
    * @param notificationTag The notificationTag of the Notification that we want to load the Bitmap.
    *     May be {@code null}.
    */
+  @SuppressLint("InlinedApi")
+  // Alert users of Glide to have this permission.
+  @RequiresPermission(Manifest.permission.POST_NOTIFICATIONS)
   public NotificationTarget(
       Context context,
       int viewId,
@@ -95,6 +101,9 @@ public NotificationTarget(
    * @param notificationTag The notificationTag of the Notification that we want to load the Bitmap.
    *     May be {@code null}.
    */
+  @SuppressLint("InlinedApi")
+  // Alert users of Glide to have this permission.
+  @RequiresPermission(Manifest.permission.POST_NOTIFICATIONS)
   public NotificationTarget(
       Context context,
       int width,
@@ -116,24 +125,36 @@ public NotificationTarget(
   }
 
   /** Updates the Notification after the Bitmap resource is loaded. */
+  @SuppressLint("InlinedApi")
+  // Help tools to recognize that this method requires a permission, because it posts a notification.
+  @RequiresPermission(Manifest.permission.POST_NOTIFICATIONS)
   private void update() {
     NotificationManager manager =
         (NotificationManager) this.context.getSystemService(Context.NOTIFICATION_SERVICE);
     Preconditions.checkNotNull(manager)
         .notify(this.notificationTag, this.notificationId, this.notification);
   }
 
+  @SuppressLint("InlinedApi")
+  // Help tools to recognize that this method requires a permission, because it calls setBitmap().
+  @RequiresPermission(Manifest.permission.POST_NOTIFICATIONS)
   @Override
   public void onResourceReady(
       @NonNull Bitmap resource, @Nullable Transition<? super Bitmap> transition) {
     setBitmap(resource);
   }
 
+  @SuppressLint("InlinedApi")
+  // Help tools to recognize that this method requires a permission, because it calls setBitmap().
+  @RequiresPermission(Manifest.permission.POST_NOTIFICATIONS)
   @Override
   public void onLoadCleared(@Nullable Drawable placeholder) {
     setBitmap(null);
   }
 
+  @SuppressLint("InlinedApi")
+  // Help tools to recognize that this method requires a permission, because it calls update().
+  @RequiresPermission(Manifest.permission.POST_NOTIFICATIONS)
   private void setBitmap(@Nullable Bitmap bitmap) {
     this.remoteViews.setImageViewBitmap(this.viewId, bitmap);
     this.update();