-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glide 4.0.0-RC0: problems with recyclerview-integration #1972
Comments
You don't want to enable multidex, but you do want to exclude the support library. A simple way to do that is to just exclude transitive dependencies when including the recycler view integration: compile "com.github.bumptech.glide:recyclerview-integration:4.0.0-RC0" {
transitive = false
} |
I still get this error:
You can find the complete project here: https://github.com/the4thfloor/PopularMovies Here's a minimal repro without using the latest alpha tools: https://groups.google.com/forum/#!msg/glidelibrary/NVhJdeVeH9U/r7B81_8PAgAJ |
@sjudd this is a packaging issue. The actual .jar file contains the @the4thfloor use implementation "com.github.bumptech.glide:recyclerview-integration:${libs.glide}@aar" the |
@TWiStErRob thanks a lot :-) |
Looking in to this now. The R class file only seems to appear in the recyclerview integration package, not the others. It's removed if I change the v7 recyclerview dependency to provided. That's probably ok, but I'm not sure I understand why it happens yet. Still need to look into the javadoc issue. |
Progress towards bumptech#1972.
I think it is as simple as the other integration libs don't reference aar dependencies. Provided to me sounds better than manually excluding these classes; it better reflects the intention. Though you don't get implicit transitive dependencies then, which may be acceptable as most people must override with a latter version anyway. |
The Android design support lib has the RecyclerView as dependency too but doesn't have this problem. |
@the4thfloor Design lib is an AAR and it depends on RecyclerView which is an AAR. recyclerview-integration is an AAR and it depends on RecyclerView which is an AAR. But there's a difference, because the recyclerview-integration is packaged as an AAR and a JAR, and only the JAR has this problem. I don't think public res would affect how JAR is packaged up. Looking at this again since yesterday, I guess the JAR magic is causing the problem only so Sam made the right call of ignoring the specific files. |
Glide Version: 4.0.0-RC0
Integration libraries: okhttp3-integration, recyclerview-integration
Issue details / Repro steps / Use case background:
My app defines 6398 classes with 41887 methods and references 50126 methods. I don't use multidex.
When I add
to my
build.gradle
I get this error:To fix this I enable
multidex
. Now I have 6151 classes with 40977 methods and 49132 methods referenced.Now the app compiles but when I run it I get this error:
Stack trace / LogCat:
I guess the important part is
ClassNotFoundException: Invalid name: android.support.v7.widget.@2131296590
but I have no idea how to fix it :-(The text was updated successfully, but these errors were encountered: