Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support incremental annotation processing #2983

Closed
stephanenicolas opened this issue Mar 25, 2018 · 4 comments
Closed

Support incremental annotation processing #2983

stephanenicolas opened this issue Mar 25, 2018 · 4 comments

Comments

@stephanenicolas
Copy link
Contributor

stephanenicolas commented Mar 25, 2018

Gradle 4.7 provides support for incremental annotation processing.
https://docs.gradle.org/nightly/userguide/java_plugin.html#sec:incremental_annotation_processing
Gradle feature discussion: gradle/gradle#1320

It would be nice to see glide's annotation processor supporting it.

I started to have a look at the code and I was surprised to find such a complex annotation processing. I don't think I can do the PR quickly by myself. But I would be happy to provide all the information I can to help a maintainer doing it.

@stephanenicolas
Copy link
Contributor Author

@sjudd I can help with it, but I as stated above, I can't do it myself. The glide AP is a bit of a monster. But I can be free for a chat. Maybe hangout ? Just find my personal email on the web and ping me there if you wanna talk about it.

@CristianGM
Copy link

Is it happening? or just forgotten?

@bingranl
Copy link

bingranl commented Oct 5, 2018

@stephanenicolas Hi Stéphane, I am going to work on it and it would be great if you can help. I find it is an aggregating AP(e.g. Looking all types annotated with @GlideExtension to create GlideOptions.java and other source files). But it violates "Aggregating AP can only read CLASS or RUNTIME retention annotations" because @GlideExtension and @GlideModule are SOURCE retention annotations. Correct me if I am wrong. Thanks @sjudd

@stephanenicolas
Copy link
Contributor Author

stephanenicolas commented Oct 6, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants