-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support incremental annotation processing #2983
Comments
@sjudd I can help with it, but I as stated above, I can't do it myself. The glide AP is a bit of a monster. But I can be free for a chat. Maybe hangout ? Just find my personal email on the web and ping me there if you wanna talk about it. |
Is it happening? or just forgotten? |
@stephanenicolas Hi Stéphane, I am going to work on it and it would be great if you can help. I find it is an aggregating AP(e.g. Looking all types annotated with |
Hi @sjudd sorry, but it's à base timing. I am taking a month off. I can't
help.
Everything should vers pretty well documented on gradle's website.
I must say I got some doubts about the possibility of making glide's AP
incremental. I am not sure but it looks like an aggregating AP.
Don't take my words for granted though!
Good luck !
Si.
Le ven. 5 oct. 2018 20:59, Bingran <[email protected]> a écrit :
… @stephanenicolas <https://github.com/stephanenicolas> Hi Stéphane, I am
going to work on it and it would be great if you can help. I find it is an
aggregating AP(e.g. Looking all types annotated with @GlideExtension to
create GlideOptions.java and other source files). But it violates
"Aggregating AP can only read CLASS or RUNTIME retention annotations"
because @GlideExtension and @GlideModule are SOURCE retention
annotations. Correct me if I am wrong. Thanks @sjudd
<https://github.com/sjudd>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2983 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABv33fYLOkbk3TuAXMPtcK-qtfXVrb4Zks5uh_J2gaJpZM4S6SFM>
.
|
Gradle 4.7 provides support for incremental annotation processing.
https://docs.gradle.org/nightly/userguide/java_plugin.html#sec:incremental_annotation_processing
Gradle feature discussion: gradle/gradle#1320
It would be nice to see glide's annotation processor supporting it.
I started to have a look at the code and I was surprised to find such a complex annotation processing. I don't think I can do the PR quickly by myself. But I would be happy to provide all the information I can to help a maintainer doing it.
The text was updated successfully, but these errors were encountered: