Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] crossFade(xxx) duration not respected #398

Closed
Tolriq opened this issue Apr 10, 2015 · 0 comments
Closed

[Bug] crossFade(xxx) duration not respected #398

Tolriq opened this issue Apr 10, 2015 · 0 comments
Labels
Milestone

Comments

@Tolriq
Copy link
Contributor

Tolriq commented Apr 10, 2015

Glide Version/Integration library (if any): 3.5.2
Device/Android Version: All
Issue details/Repro steps:
Use .crossFade(2500) without using .placeholder(mDefaultImageResource)

Glide load line:

        Glide.with(ctx)
                .load(DisplayHelper.getGlideImageRequest(buffer))
                .centerCrop()
                .error(mDefaultErrorResource)
                .crossFade(250)
                .into((ImageView) view.getTag(imageViewId));

From the doc crossFade should fade in when there's no place holder.

But in the cases where there's no placeHolder the duration parameter is not applied.

@sjudd sjudd added the bug label Apr 13, 2015
@sjudd sjudd added this to the 3.6.0 milestone Apr 13, 2015
@sjudd sjudd closed this as completed in 899e41b Apr 13, 2015
sjudd added a commit to sjudd/glide that referenced this issue Apr 14, 2015
Fixes bumptech#398.
Conflicts:
	library/src/main/java/com/bumptech/glide/request/GenericRequest.java
	library/src/main/java/com/bumptech/glide/request/animation/DrawableCrossFadeFactory.java
	samples/flickr/src/main/java/com/bumptech/glide/samples/flickr/FlickrPhotoGrid.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants