Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move calculating the total iteration count of an animated GIF from GifDrawable to GifDecoder #1836

Merged
merged 1 commit into from
Apr 12, 2017
Merged

Move calculating the total iteration count of an animated GIF from GifDrawable to GifDecoder #1836

merged 1 commit into from
Apr 12, 2017

Conversation

ghost
Copy link

@ghost ghost commented Apr 4, 2017

Refactoring that addresses the comments on #1813

  • Rename getNetscapeIterationCount() to getNetscapeLoopCount() in GifDecoder
  • Move calculating the total iteration count of an animated GIF from GifDrawable#setLoopCount() to GifDecoder#getTotalIterationCount()

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 83.345% when pulling 0bd17e1 on toyama-sumio:add-get-total-iteration-count into 6d83cf1 on bumptech:3.0.

@sjudd
Copy link
Collaborator

sjudd commented Apr 11, 2017

@TWiStErRob Might you have time to look at this? Or should I?

@TWiStErRob
Copy link
Collaborator

Sorry, didn't have time to clear my queue this weekend. I'll check when I get home soon.

TWiStErRob
TWiStErRob approved these changes Apr 11, 2017
View reviewed changes
Copy link
Collaborator

@TWiStErRob TWiStErRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, beautiful JavaDocs!
Thank you for taking the time to do this, and sorry for the delay.

@TWiStErRob TWiStErRob assigned sjudd and unassigned TWiStErRob Apr 11, 2017
@TWiStErRob TWiStErRob added this to the 3.8.0 milestone Apr 11, 2017
@sjudd
Copy link
Collaborator

sjudd commented Apr 12, 2017

Thanks!

@sjudd sjudd merged commit 2c6388e into bumptech:3.0 Apr 12, 2017
@ghost
Copy link
Author

ghost commented Apr 13, 2017

Thanks for reviewing and merging!

@ghost ghost deleted the add-get-total-iteration-count branch April 13, 2017 02:45
ghost pushed a commit to sumio/glide that referenced this pull request Apr 24, 2017
Forward port PR bumptech#1813 and bumptech#1836 from 3.0 to master: F…
7534895 
…ix wrong interpretation of the Netscape iteration count in an animated GIF.

Fixed bumptech#1724
@ghost ghost mentioned this pull request Apr 24, 2017
Merged
sjudd added a commit that referenced this pull request May 3, 2017
@sjudd
Merge pull request #1875 from toyama-sumio/fix-gif-loopcount-for-4.0
06cf811 
Forward port PR #1813 and #1836 : Fix wrong interpretation of the loop count in an animated GIF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sjudd sjudd

Labels
enhancement
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@coveralls @sjudd @TWiStErRob