Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart any non-running identical requests instead of ignoring them. #2261

Merged
merged 1 commit into from
Aug 18, 2017

Conversation

sjudd
Copy link
Collaborator

@sjudd sjudd commented Aug 18, 2017

Running requests are left to complete to avoid cancelling and restarting expensive operations (network or I/O). Completed requests are asked to begin again, but short cut the normal request pipeline and redeliver the previously loaded resource to ensure that Targets and RequestListeners are notified as expected. Failed, cancelled, paused etc requests (all other states) are simply restarted.

This might resolve #2245

Running requests are left to complete to avoid cancelling and restarting
expensive operations (network or I/O). Completed requests are asked to
begin again, but short cut the normal request pipeline and redeliver the previously loaded resource to ensure that Targets and RequestListeners 
are notified as expected. Failed, cancelled, paused etc requests (all 
other states) are simply restarted.
@sjudd sjudd merged commit 73a8e01 into bumptech:master Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glide 4.1 side effect of ignore identical request.
1 participant