-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override default Encoders #2349
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
bff50d9
to
0f6273c
Compare
CLAs look good, thanks! |
* data class. | ||
* | ||
* <p>This method allows you to replace the default {@link Encoder} because it ensures | ||
* the registered {@link Encoder} will run first. You can return false in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Returning false will cause the load to fail. There isn't currently any logic that tries Encoders in order, it just assumes there's one per data type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Encoder<Object> encoder = helper.getSourceEncoder(dataToCache); |
* so that it is attempted before all later and default {@link ResourceEncoder}s for the given | ||
* data type. | ||
* | ||
* <p>This method allows you to replace the default {@link ResourceEncoder} because it ensures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here:
diskCacheProvider.getDiskCache().put(key, |
Other than the two minor comments I made, looks good. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed comments to describe current behaviour. Thanks!
LGTM, thanks! |
Description
Override default Encoders for existing data classes. I've added prepend methods to Encoder and ResourceEncoder classes to achieve this.
Motivation and Context
I want to encrypt images in Glide disk cache. To do that I need to be able to replace Encoders for existing data types like Bitmap, InputStream, Drawable, etc.