Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override default Encoders #2349

Merged
merged 2 commits into from
Sep 8, 2017
Merged

Conversation

MistaGreen
Copy link
Contributor

Description

Override default Encoders for existing data classes. I've added prepend methods to Encoder and ResourceEncoder classes to achieve this.

Motivation and Context

I want to encrypt images in Glide disk cache. To do that I need to be able to replace Encoders for existing data types like Bitmap, InputStream, Drawable, etc.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@MistaGreen
Copy link
Contributor Author

I signed it

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot
Copy link

CLAs look good, thanks!

* data class.
*
* <p>This method allows you to replace the default {@link Encoder} because it ensures
* the registered {@link Encoder} will run first. You can return false in
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returning false will cause the load to fail. There isn't currently any logic that tries Encoders in order, it just assumes there's one per data type.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Encoder<Object> encoder = helper.getSourceEncoder(dataToCache);

* so that it is attempted before all later and default {@link ResourceEncoder}s for the given
* data type.
*
* <p>This method allows you to replace the default {@link ResourceEncoder} because it ensures
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here:

diskCacheProvider.getDiskCache().put(key,

@sjudd
Copy link
Collaborator

sjudd commented Sep 7, 2017

Other than the two minor comments I made, looks good. Thanks!

Copy link
Contributor Author

@MistaGreen MistaGreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed comments to describe current behaviour. Thanks!

@sjudd
Copy link
Collaborator

sjudd commented Sep 8, 2017

LGTM, thanks!

@sjudd sjudd merged commit 03f5bd4 into bumptech:master Sep 8, 2017
@TWiStErRob TWiStErRob added this to the 4.2 milestone Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants