Change library dependencies configuration from api to compileOnly #2734
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it!
2017-12-19 16:22 GMT+08:00 googlebot <[email protected]>:
… Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 *Please visit https://cla.developers.google.com/
<https://cla.developers.google.com/> to sign.*
Once you've signed, please reply here (e.g. I signed it!) and we'll
verify. Thanks.
------------------------------
- If you've already signed a CLA, it's possible we don't have your
GitHub username or you're using a different email address on your commit.
Check your existing CLA data <https://cla.developers.google.com/clas>
and verify that your email is set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
- If your company signed a CLA, they designated a Point of Contact who
decides which employees are authorized to participate. You may need to
contact the Point of Contact for your company and ask to be added to the
group of authorized contributors. If you don't know who your Point of
Contact is, direct the project maintainer to go/cla#troubleshoot. The email
used to register you as an authorized contributor must be the email used
for the Git commit.
- In order to pass this check, please resolve this problem and have
the pull request author add another comment and the bot will run again. If
the bot doesn't comment, it means it doesn't think anything has changed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2734 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEk0gVM1cTfhxMx9rMRdpQPrdbXcYt6wks5tB3JKgaJpZM4RGl2h>
.
|
|
CLAs look good, thanks! |
|
I don't think this makes sense. With the PR, you'll get a compilation error unless you add a dependency on the support library at the same time that you add a dependency on Glide, which isn't how Gradle is supposed to work. Using Gradle's existing tools to handle conflicting dependencies if you don't want Glide's version of the support library or don't like how Gradle is resolving your dependencies seems like the right answer. Let me know if you think that's incorrect. |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
I have added support-annotations in gifencoder like other third-party library did(okhttp,gifdecoder), and there is no complication fail again.(travis check failed is same as issue #2738) |
|
We can't be transparent about which version we use. Using compileOnly breaks users who don't depend on the support library already. |
|
Agree, I'll close this PR |
Description
Library's dependencies' version is 27.0.2, this change can fix the conflict with version 26.1.0 support dependency in user's code.
fixed #2730
Motivation and Context