Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing annotations on APT overriding methods #2779

Merged
merged 5 commits into from
Jan 2, 2018
Merged

Add missing annotations on APT overriding methods #2779

merged 5 commits into from
Jan 2, 2018

Conversation

TWiStErRob
Copy link
Collaborator

Description

  • Added annotations
  • Connect up the test module with the apt compiler, so it's harder to forget to run the tests.

Motivation and Context

image

@TWiStErRob TWiStErRob requested a review from sjudd January 1, 2018 16:34
@TWiStErRob
Copy link
Collaborator Author

Related to #2774

@sjudd
Copy link
Collaborator

sjudd commented Jan 2, 2018

Thanks!

@sjudd sjudd merged commit d7bb6f9 into bumptech:master Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjudd sjudd Awaiting requested review from sjudd

Assignees

@sjudd sjudd

Labels
cla: yes enhancement v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TWiStErRob @sjudd @googlebot