Start adding nullability annotations to load package #2797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
|
@sjudd Any updates? 😊 |
sjudd
requested changes
Jan 18, 2018
| @@ -58,6 +58,7 @@ public DrawableTransformation(Transformation<Bitmap> wrapped, boolean isRequired | |||
| return resource; | |||
| } | |||
| } | |||
| // TODO bitmapResourceToTransform can be null, what to do? | |||
There was a problem hiding this comment.
It will be non-null if you reach this point, I believe you can remove this todo.
There was a problem hiding this comment.
@sjudd Oh you're right, thanks!
Signed-off-by: Alex Saveau <[email protected]>
|
@sjudd No problem! (And we have a green build!) |
|
Thanks! |
sjudd
approved these changes
Jan 23, 2018
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.