Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGP: Upgrade AndroidManifest.xml's package to build.gradle's namespace. #5221

Merged
merged 7 commits into from
Aug 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion annotation/compiler/test/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ afterEvaluate {
}

android {
namespace 'com.bumptech.glide.annotation.compiler.test'
compileSdk libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down Expand Up @@ -94,4 +95,3 @@ task regenerateTestResources {
afterEvaluate {
regenerateTestResources.finalizedBy(testReleaseUnitTest)
}

4 changes: 0 additions & 4 deletions annotation/compiler/test/src/main/AndroidManifest.xml

This file was deleted.

3 changes: 2 additions & 1 deletion annotation/ksp/integrationtest/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ plugins {
}

android {
namespace 'com.bumptech.glide.annotation.ksp.integrationtest'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand All @@ -35,4 +36,4 @@ dependencies {
testImplementation libs.truth
testImplementation libs.kotlin.test
testImplementation project(path: ':annotation:ksp:test')
}
}
5 changes: 0 additions & 5 deletions annotation/ksp/integrationtest/src/main/AndroidManifest.xml

This file was deleted.

3 changes: 2 additions & 1 deletion annotation/ksp/test/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ plugins {
}

android {
namespace 'com.bumptech.glide.annotation.ksp.test'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand All @@ -22,4 +23,4 @@ dependencies {
testImplementation project(":annotation")
testImplementation project(":glide")
testImplementation libs.kotlin.test
}
}
5 changes: 0 additions & 5 deletions annotation/ksp/test/src/main/AndroidManifest.xml

This file was deleted.

3 changes: 2 additions & 1 deletion benchmark/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ plugins {
}

android {
namespace 'com.bumptech.glide.benchmark'
compileSdkVersion libs.versions.compile.sdk.version.get()

buildToolsVersion "30.0.3"
Expand Down Expand Up @@ -41,4 +42,4 @@ dependencies {
androidTestImplementation project(':testutil')
androidTestImplementation libs.androidx.benchmark.junit
androidTestImplementation libs.guava
}
}
5 changes: 2 additions & 3 deletions benchmark/src/androidTest/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
package="com.bumptech.glide.benchmark">
xmlns:tools="http://schemas.android.com/tools">

<!--
Important: disable debugging for accurate performance results
Expand All @@ -14,4 +13,4 @@
tools:ignore="HardcodedDebugMode"
tools:replace="android:debuggable" >
</application>
</manifest>
</manifest>
4 changes: 0 additions & 4 deletions benchmark/src/main/AndroidManifest.xml

This file was deleted.

3 changes: 1 addition & 2 deletions instrumentation/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.instrumentation'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
applicationId 'com.bumptech.glide.instrumentation'
minSdk libs.versions.min.sdk.version.get() as int
targetSdk libs.versions.target.sdk.version.get() as int
versionCode 1
Expand All @@ -53,4 +53,3 @@ android {
}
}
}

5 changes: 3 additions & 2 deletions instrumentation/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
package="com.bumptech.glide.instrumentation">
xmlns:tools="http://schemas.android.com/tools">

<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
<uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW" />
<application
Expand Down
1 change: 1 addition & 0 deletions integration/avif/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.integration.avif'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
2 changes: 0 additions & 2 deletions integration/avif/src/main/AndroidManifest.xml

This file was deleted.

1 change: 1 addition & 0 deletions integration/compose/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ plugins {
}

android {
namespace 'com.bumptech.glide.integration.compose'
compileSdk 33

defaultConfig {
Expand Down
5 changes: 0 additions & 5 deletions integration/compose/src/main/AndroidManifest.xml

This file was deleted.

1 change: 1 addition & 0 deletions integration/concurrent/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.integration.concurrent'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
6 changes: 0 additions & 6 deletions integration/concurrent/src/main/AndroidManifest.xml

This file was deleted.

1 change: 1 addition & 0 deletions integration/cronet/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.integration.cronet'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
5 changes: 3 additions & 2 deletions integration/cronet/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.bumptech.glide.integration.cronet">
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

<application>
<meta-data
android:name="com.bumptech.glide.integration.cronet.CronetGlideModule"
Expand Down
5 changes: 1 addition & 4 deletions integration/cronet/src/test/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.bumptech.glide.integration.cronet">
<application />
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
<uses-sdk android:minSdkVersion="14" android:targetSdkVersion="26"/>
</manifest>

1 change: 1 addition & 0 deletions integration/gifencoder/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.integration.gifencoder'
compileSdkVersion libs.versions.compile.sdk.version.get()

sourceSets {
Expand Down
6 changes: 0 additions & 6 deletions integration/gifencoder/src/main/AndroidManifest.xml

This file was deleted.

1 change: 1 addition & 0 deletions integration/ktx/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ plugins {
}

android {
namespace 'com.bumptech.glide.integration.ktx'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
2 changes: 0 additions & 2 deletions integration/ktx/src/main/AndroidManifest.xml

This file was deleted.

1 change: 1 addition & 0 deletions integration/okhttp/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.integration.okhttp'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
5 changes: 0 additions & 5 deletions integration/okhttp/src/main/AndroidManifest.xml

This file was deleted.

1 change: 1 addition & 0 deletions integration/okhttp3/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.integration.okhttp'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
4 changes: 2 additions & 2 deletions integration/okhttp3/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.bumptech.glide.integration.okhttp">
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

<application>
<meta-data
Expand Down
1 change: 1 addition & 0 deletions integration/okhttp4/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.integration.okhttp'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
5 changes: 0 additions & 5 deletions integration/okhttp4/src/main/AndroidManifest.xml

This file was deleted.

1 change: 1 addition & 0 deletions integration/recyclerview/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.integration.recyclerview'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
5 changes: 0 additions & 5 deletions integration/recyclerview/src/main/AndroidManifest.xml

This file was deleted.

1 change: 1 addition & 0 deletions integration/sqljournaldiskcache/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ plugins {
}

android {
namespace 'com.bumptech.glide.integration.sqljournaldiskcache'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
5 changes: 0 additions & 5 deletions integration/sqljournaldiskcache/src/main/AndroidManifest.xml

This file was deleted.

1 change: 1 addition & 0 deletions integration/volley/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.integration.volley'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
3 changes: 1 addition & 2 deletions integration/volley/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.bumptech.glide.integration.volley">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

<application>
<meta-data
Expand Down
1 change: 1 addition & 0 deletions library/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ if (project.plugins.hasPlugin('net.ltgt.errorprone')) {
}

android {
namespace 'com.bumptech.glide'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
5 changes: 0 additions & 5 deletions library/src/main/AndroidManifest.xml

This file was deleted.

1 change: 1 addition & 0 deletions library/test/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ android.testOptions.unitTests.all { Test testTask ->
}

android {
namespace 'com.bumptech.glide.test'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
4 changes: 0 additions & 4 deletions library/test/src/main/AndroidManifest.xml

This file was deleted.

1 change: 1 addition & 0 deletions mocks/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.mocks'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
Expand Down
4 changes: 0 additions & 4 deletions mocks/src/main/AndroidManifest.xml

This file was deleted.

2 changes: 1 addition & 1 deletion samples/contacturi/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.samples.contacturi'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
applicationId 'com.bumptech.glide.samples.contacturi'
minSdk libs.versions.min.sdk.version.get() as int
targetSdk libs.versions.target.sdk.version.get() as int

Expand Down
3 changes: 1 addition & 2 deletions samples/contacturi/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.bumptech.glide.samples.contacturi" >
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

<uses-permission android:name="android.permission.READ_CONTACTS" />

Expand Down
2 changes: 1 addition & 1 deletion samples/flickr/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ dependencies {
}

android {
namespace 'com.bumptech.glide.samples.flickr'
compileSdkVersion libs.versions.compile.sdk.version.get()

defaultConfig {
applicationId 'com.bumptech.glide.samples.flickr'
minSdk libs.versions.min.sdk.version.get() as int
targetSdk libs.versions.target.sdk.version.get() as int

Expand Down
3 changes: 1 addition & 2 deletions samples/flickr/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
package="com.bumptech.glide.samples.flickr">
xmlns:tools="http://schemas.android.com/tools">

<uses-permission android:name="android.permission.INTERNET"/>
<!--
Expand Down
Loading