-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting okhttp3 integration to Glide 3 #887
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed the CLA. |
Awesome, lgtm. Reminder: #257 will need a re-fix for this as well. |
Thanks -- I couldn't really tell what the version strategy was, so I tried to be consistent with what was in the other integrations. |
Yes, you did good. The current idea is that all integration libs have the same version, separate from the main lib's version (this might change with 4.0). I tried to make it more obvious by removing duplication, but it didn't work, resulting in GRADLE-3380. |
LGTM, thanks! Would you mind squashing your commits? If not I'll get to it soon. |
updating import arrangement
squashed |
Awesome thanks! |
Porting okhttp3 integration to Glide 3
Of course -- they upgrade off RC one day later. I'll look at updating it next week. |
Glide 3 using sync call with OkHttp without callback, so I think it could upgrade the version directly. |
Would you mind publish a new stable release for Glide 3 with OkHttp 3.0 integration? |
} | ||
|
||
dependencies { | ||
compile project(':library') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we missed this, see #941
Library module in v3 is not published, everything there depends on :glide
as far as I remember.
I ported the okhttp3 integration to the Glide 3 branch, see #856