Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting okhttp3 integration to Glide 3 #887

Merged
merged 1 commit into from
Jan 14, 2016
Merged

Porting okhttp3 integration to Glide 3 #887

merged 1 commit into from
Jan 14, 2016

Conversation

frindly
Copy link

@frindly frindly commented Jan 13, 2016

I ported the okhttp3 integration to the Glide 3 branch, see #856

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@frindly
Copy link
Author

frindly commented Jan 13, 2016

I signed the CLA.

@TWiStErRob
Copy link
Collaborator

Awesome, lgtm.

Reminder: #257 will need a re-fix for this as well.

@TWiStErRob
Copy link
Collaborator

Oh and I opened #888 because the version looks weird compared to the v4 okhttp3 one. @frindly you needn't worry about this.

@frindly
Copy link
Author

frindly commented Jan 13, 2016

Thanks -- I couldn't really tell what the version strategy was, so I tried to be consistent with what was in the other integrations.

@TWiStErRob
Copy link
Collaborator

Yes, you did good. The current idea is that all integration libs have the same version, separate from the main lib's version (this might change with 4.0). I tried to make it more obvious by removing duplication, but it didn't work, resulting in GRADLE-3380.

@sjudd
Copy link
Collaborator

sjudd commented Jan 13, 2016

LGTM, thanks! Would you mind squashing your commits? If not I'll get to it soon.

updating import arrangement
@frindly
Copy link
Author

frindly commented Jan 14, 2016

squashed

@sjudd
Copy link
Collaborator

sjudd commented Jan 14, 2016

Awesome thanks!

sjudd added a commit that referenced this pull request Jan 14, 2016
Porting okhttp3 integration to Glide 3
@sjudd sjudd merged commit 7709c36 into bumptech:3.0 Jan 14, 2016
@TWiStErRob
Copy link
Collaborator

@frindly you may be interested in #897

@frindly
Copy link
Author

frindly commented Jan 15, 2016

Of course -- they upgrade off RC one day later. I'll look at updating it next week.

@b95505017
Copy link
Contributor

Glide 3 using sync call with OkHttp without callback, so I think it could upgrade the version directly.

@b95505017
Copy link
Contributor

Would you mind publish a new stable release for Glide 3 with OkHttp 3.0 integration?

@TWiStErRob TWiStErRob added this to the 3.7.0 milestone Jan 21, 2016
}

dependencies {
compile project(':library')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we missed this, see #941
Library module in v3 is not published, everything there depends on :glide as far as I remember.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants