Skip to content

Commit

Permalink
fix ui height + select auto submit
Browse files Browse the repository at this point in the history
*remove useless scroll on UI due to footer and absolute <main>
*add type="button" to aria-controls role="listbox" to avoid auto submit on click
  • Loading branch information
syrk4web committed Dec 26, 2023
1 parent e348e92 commit 3321190
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/ui/templates/base.html
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

<!-- info -->
<main
class="absolute xl:pl-75 w-full px-2 sm:px-6 pb-0 pt-20 sm:pt-6 min-h-[80vh] h-full flex flex-col justify-between"
class="xl:pl-75 w-full px-2 sm:px-6 pb-0 pt-20 sm:pt-6 min-h-[80vh] h-full flex flex-col justify-between"
>
<div
class="max-w-[1920px] grid gap-y-4 gap-3 sm:gap-4 lg:gap-6 grid-cols-12 w-full"
Expand Down
2 changes: 2 additions & 0 deletions src/ui/templates/settings_plugins.html
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@
data-default-value="{{global_config[setting]['value']}}"
data-default-method="{{global_config[setting]['method']}}"
aria-controls="{{value['id']}}-dropdown"
type="button"
class="custom-select-btn"
>
{% for item in value['select'] %} {% if global_config[setting]['value'] and
Expand Down Expand Up @@ -319,6 +320,7 @@
data-setting-select="{{value['id']}}"
data-default-value="{{value['default']}}"
aria-controls="{{value['id']}}-dropdown"
type="button"
class="custom-select-btn"
>
{% for item in value['select'] %} {% if value['default'] == item %}
Expand Down

0 comments on commit 3321190

Please sign in to comment.