Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint failure #1478

Closed
alifeee opened this issue Jun 8, 2024 · 1 comment · Fixed by #1481
Closed

lint failure #1478

alifeee opened this issue Jun 8, 2024 · 1 comment · Fixed by #1481
Labels
Bug help wanted Need investigation This issue needs to be tested or investigated

Comments

@alifeee
Copy link
Collaborator

alifeee commented Jun 8, 2024

The linting is failing now

https://github.com/burnash/gspread/actions

What has changed? I am not sure.

Here is a working workflow https://github.com/burnash/gspread/actions/runs/9259695428/job/25472114091

working.txt

Here is a broken one https://github.com/burnash/gspread/actions/runs/9259695827/job/25472115123

workingnot.txt

I don't see a big difference in the lint step

image

This requires more investigating.

@lavigne958
Copy link
Collaborator

I checked,

On this workflow:
https://github.com/burnash/gspread/actions/runs/9259695827/job/25472115123

We use a more recent version of codespell which triggers on new errors. At least it triggers some errors on false positive checks. It triggers on code or it should only trigger in pure text.

So this is why I closed the associated PR.

My concern is on this issue:

https://github.com/burnash/gspread/actions/runs/9332077295/job/25687472543

But I'll open a PR today to skip this check. Any check or safety on pip we don't care so much.

alifeee pushed a commit that referenced this issue Oct 3, 2024
closes #1478

Signed-off-by: Alexandre Lavigne <[email protected]>
(cherry picked from commit 16a62ef)
alifeee pushed a commit that referenced this issue Oct 3, 2024
closes #1478

Signed-off-by: Alexandre Lavigne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug help wanted Need investigation This issue needs to be tested or investigated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants