Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrize not only authorized_user_filename but also credentials_filename #889

Closed
slmtpz opened this issue Jul 6, 2021 · 2 comments · Fixed by #891
Closed

Parametrize not only authorized_user_filename but also credentials_filename #889

slmtpz opened this issue Jul 6, 2021 · 2 comments · Fixed by #891
Assignees
Milestone

Comments

@slmtpz
Copy link
Contributor

slmtpz commented Jul 6, 2021

Is your feature request related to a problem? Please describe.
While instantiating a client using gspread.auth.oauth(), the latest release v3.7.0 does not parameterize the filenames. However, in master, I see that authorized_user.json file is parametrized already. I think it's for the best the file used by auth flow, namely credentials.json is parametrized among oauth() inputs.

Describe the solution you'd like
Allow the users to pass credentials_filename and use it during Google browser auth flow. Pass the file path to downstream functions that need it.

Describe alternatives you've considered
Not an alternative but maybe while there, it could be nice if filenames are renamed to filepaths as for instance DEFAULT_CREDENTIALS_FILENAME is not actually a file name but a file path.

@slmtpz
Copy link
Contributor Author

slmtpz commented Jul 6, 2021

I can pick this up if the work sounds good

@slmtpz slmtpz changed the title Parametrize not only authorized_user_filename but also credentials_filename and service_accounts_filename Parametrize not only authorized_user_filename but also credentials_filename Jul 6, 2021
@burnash
Copy link
Owner

burnash commented Jul 7, 2021

@slmtpz sounds good. Please go ahead.

Regarding the "filename", I know its arguable but I'd leave it as it is to stay consistent with google-auth which uses the word "filename" for path to files parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants