-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update (and test for) internal properties on change #1211
Conversation
(this does not add any new requests, so no new cassettes need to be recorded :)
it wasn't actually testing for anything before since only 1 sheet cannot reorder now we add more sheets also had to add cassette
by updating internal state
Currently this line fails.
this calls this sets Then, isSheetHidden attempts to get ok, I figured out the problem was that in the |
not old sheet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good To Me
Here are all Worksheet properties - what changes them - whether this method updates local prop: ✅/❌
|
Closes #1201
Many internal properties were not updated
These updates were also not tested for in the tests.
More info in #1201