fix type issue (remove .first()
function)
#1344
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was not caught by #1296's CI because type-checking was not yet enabled in the workflow.
This is the main change:
...which replaces the call to
ValueRange.first()
with its implementationgspread/gspread/worksheet.py
Lines 140 to 148 in 6944c1f
The error was because before #1296,
get
returned aValueRange
. After #1296, it returnsValueRange | List[List[Any]]
, so the type checking complained that.first()
was not a method onList[List[Any]]
. I'm not sure how to solve this issue by typinig, which is why I did what I did here.Why is
.first()
needed as a function anyway? It is hardly used. I propose that we don't need it (but we should keep it, and just not use it internally).