Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/release 6 0 0 #1382

Merged
merged 185 commits into from
Jan 27, 2024
Merged

Feature/release 6 0 0 #1382

merged 185 commits into from
Jan 27, 2024

Conversation

lavigne958
Copy link
Collaborator

Merge all changes related to v6.0.0 !

closes #1380

cgkoutzigiannis and others added 30 commits June 15, 2022 14:40
Minimum verison: 3.7 (currently oldest version)
build verison: 3.8
test versions: from 3.7 to 3.11, 3.12 dev version

closes #1152
The remova of this method is already handled by #1062

This reverts commit 402fc00.
Add first typped file: `url.py`.
We must force cast JSON returned dict to a dict for mypy to see it
Bumps [isort](https://github.com/pycqa/isort) from 5.11.4 to 5.12.0.
- [Release notes](https://github.com/pycqa/isort/releases)
- [Changelog](https://github.com/PyCQA/isort/blob/main/CHANGELOG.md)
- [Commits](PyCQA/isort@5.11.4...5.12.0)

---
updated-dependencies:
- dependency-name: isort
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
alifeee and others added 21 commits November 7, 2023 12:05
increase warning stacklevel from 1 to 2
Skip CVE directly related to wrong pip version, we only use it a tool for the CI to run the package
we don't actually use it in production, we don't handle nor manage pip versions
see #1367
rearrange kwargs and docstring kwargs
this simplifies the method a lot (as discussed in #1367)

had to change some tests
- replace get_records with get_all_records
- remove testing logic that use `first_index` and `last_index`. these are no longer supported
Add a new util function that helps building record values.
Records are list of dictionaries, each dictionary has the same
set of keys, they are set from the given list of headers.
Each key is associated to a value from the given matrix of values.
They are as many dictionaries as they are lines in the matrix.

Each line in the matrix will be associated to a dictionary,
each key is associated to a value from that line in the given order.

Example:
Headers: A B C
Values:
1 2 3
7 8 9
Result: [ { A: 1, B: 2, C: 3}, {A: 7, B: 8, C: 9}]

closes #1367

Signed-off-by: Alexandre Lavigne <[email protected]>
Add util function `to_records` to build records
…ecords"

This reverts commit d7c110f, reversing
changes made to 63c4c5e.
Add the new section in the v6 migration guide about
the method `Worksheet.get_all_records` to allow users
to migrate from previous method signature to the new one.

closes #1376

Signed-off-by: Alexandre Lavigne <[email protected]>
Add a new util function that helps building record values.
Records are list of dictionaries, each dictionary has the same
set of keys, they are set from the given list of headers.
Each key is associated to a value from the given matrix of values.
They are as many dictionaries as they are lines in the matrix.

Each line in the matrix will be associated to a dictionary,
each key is associated to a value from that line in the given order.

Example:
Headers: A B C
Values:
1 2 3
7 8 9
Result: [ { A: 1, B: 2, C: 3}, {A: 7, B: 8, C: 9}]

closes #1367

Signed-off-by: Alexandre Lavigne <[email protected]>
…se_6_0_0

feature/merge master into release 6 0 0
@lavigne958 lavigne958 requested a review from alifeee January 27, 2024 09:07
@lavigne958 lavigne958 self-assigned this Jan 27, 2024
@alifeee
Copy link
Collaborator

alifeee commented Jan 27, 2024

20,000 lines is a few too many for me to look at each... but I had a skim, and the tests work.

let's merge :)

@lavigne958
Copy link
Collaborator Author

20,000 lines is a few too many for me to look at each... but I had a skim, and the tests work.

let's merge :)

😆 Of course.

Now we just hope it works as planned 😬

@lavigne958 lavigne958 merged commit 2dd69eb into master Jan 27, 2024
10 checks passed
@lavigne958 lavigne958 deleted the feature/release_6_0_0 branch January 27, 2024 11:08
@lavigne958
Copy link
Collaborator Author

It's done! I thought that day would never come 🤩

I hope everyone will like it 🙄

@alifeee
Copy link
Collaborator

alifeee commented Jan 27, 2024

wow!

I will release as I said tomorrow (Sunday) at 12:00 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge Master into branch feature/release_6_0_0
6 participants