Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore pip vulnerabilities in CI. #1464

Merged
merged 1 commit into from
May 13, 2024
Merged

Ignore pip vulnerabilities in CI. #1464

merged 1 commit into from
May 13, 2024

Conversation

lavigne958
Copy link
Collaborator

ignore pip vulnerabilities in CI, we don't ship pip.

Signed-off-by: Alexandre Lavigne <[email protected]>
@lavigne958 lavigne958 added this to the 6.1.1 milestone May 12, 2024
@lavigne958 lavigne958 requested a review from alifeee May 12, 2024 14:44
@alifeee
Copy link
Collaborator

alifeee commented May 13, 2024

what does this fix? did the CI break?

@alifeee
Copy link
Collaborator

alifeee commented May 13, 2024

@alifeee
Copy link
Collaborator

alifeee commented May 13, 2024

I know I said I wouldn't merge your PRs... but I think this is a small enough change... and I am trying to work on other PRs that have failing CI... will merge this...

@alifeee alifeee merged commit 476211f into master May 13, 2024
10 checks passed
@alifeee alifeee deleted the ci/ignore_pip_issue branch May 13, 2024 13:07
@lavigne958
Copy link
Collaborator Author

I know I said I wouldn't merge your PRs... but I think this is a small enough change... and I am trying to work on other PRs that have failing CI... will merge this...

No worries, I appreciate the heads-up and it's worth it for you to move forward 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants