Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow auth to be None. Fix #773 #774

Merged
merged 2 commits into from
May 19, 2020
Merged

Allow auth to be None. Fix #773 #774

merged 2 commits into from
May 19, 2020

Conversation

lepture
Copy link
Contributor

@lepture lepture commented May 18, 2020

This fixed #773

cc @burnash I'd like to suggest using Authlib instead of google.auth. With Authlib, you just need to add very little code for the auth part in gspread. Check out: https://blog.authlib.org/2018/authlib-for-gspread

@burnash burnash merged commit 22b76a7 into burnash:master May 19, 2020
@burnash
Copy link
Owner

burnash commented May 19, 2020

@lepture thank you very much for the fix and for Authlib.

Authlib is a great option however I think I'll stick with google.auth for now. Initially, I thought that decoupling gspread from oauth handlers was a good idea, however, after #637 and #711 the integration with google.auth has been working pretty well so far. Also allowed to easily implement nice shortcuts for auth: gspread.oauth() and gspread.service_account().

@lepture lepture deleted the fix-773 branch May 19, 2020 12:22
@ghost
Copy link

ghost commented May 21, 2020

Thank you for the fix @lepture. When would be the next release? Would really like to have this in the official package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants