Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlexColumn: add minWidth maxWidth props #106

Closed
Guria opened this issue Feb 17, 2016 · 2 comments
Closed

FlexColumn: add minWidth maxWidth props #106

Guria opened this issue Feb 17, 2016 · 2 comments
Labels
enhancement

Comments

@Guria
Copy link

Guria commented Feb 17, 2016

Is it able to add support off minWidth and maxWidth props for FlexColumn?
@bvaughn bvaughn mentioned this issue Feb 18, 2016
Merged
@bvaughn
Copy link
Owner

bvaughn commented Feb 18, 2016

Hm. It's possible to add this, although I'm not sure how I feel about it. You have to specify a width. If you chose to specify a maxWidth you'd have to also make sure flexGrow was greater than 0 or it would have no affect.

I've pushed PR #111 which adds this feature but I'm going to leave it sit for a while so I can think over it. I'm also temporarily more focused on trying to verify a fix for #2.

bvaughn added a commit that referenced this issue Feb 18, 2016
@bvaughn
Merge pull request #111 from /issues/106
3bc78de 
Add min/max width attributes to FlexColumn.
@bvaughn
Copy link
Owner

bvaughn commented Feb 18, 2016

Look for this to go out momentarily with the 5.2.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bvaughn @Guria