New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade next to v14 and downgrade sharp to v0.32 #266

Merged

tianzhou merged 1 commit into bytebase:main from zzjin:main

Dec 24, 2023

Contributor

zzjin commented Dec 23, 2023 •

edited

Loading

There are two bugs, fixed by one pr:

upgrade next version to latest v14 to prevent ssl load of internal images.
@see:

How run next.js with node-sharp for docker vercel/next.js#35296
next/image "url" parameter is valid but upstream response is invalid vercel/next.js#53715
use experimentalHttpsServer flag when determining image optimizer protocol vercel/next.js#55988
Image component does not work with https next dev vercel/next.js#55706
Urgent - next/image "url" parameter is valid but upstream response is invalid (2) vercel/next.js#58248
downgrade sharp to support next standalone build flag.
@see:

Next JS with Sharp in docker container lovell/sharp#3877
Vercel only: 0.33.0: error Could not load the "sharp" module using the linux-x64 runtime lovell/sharp#3870
@vercel/nft does not pick up platform-specific binaries for sharp vercel/nft#371
Standalone export Sharp executable is not present with pnpm vercel/next.js#59346

closes: #265


          fix: upgrade next to v14 and downgrade sharp to v0.32

6682a3e

Signed-off-by: zzjin <[email protected]>

vercel bot commented Dec 23, 2023

@zzjin is attempting to deploy a commit to the bytebase Team on Vercel.

A member of the Team first needs to authorize it.

Member

tianzhou commented Dec 24, 2023

Thank you for the PR

tianzhou approved these changes

View reviewed changes

Member

tianzhou left a comment

LGTM

tianzhou merged commit 0ace424 into bytebase:main

1 of 2 checks passed

emilioaray-dev commented Jan 26, 2024

There is no error, however the image conversion from jpg to webp does not work,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet