-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wasm_opt #114
base: main
Are you sure you want to change the base?
fix: wasm_opt #114
Conversation
Oops, some checks are stills be not successful, IMHO maybe
rustwasm/wasm-bindgen#2554 (comment) Or, we should allow users to pass and override the cargo wasi build -p markdown --release --verbose --target wasm32-unknown-unknown Lines 82 to 94 in 6d2e502
|
058155e
to
3364dab
Compare
|
Sorry there's a good number of changes here and I don't have a ton of time to review this right now. If wasm-opt-the-builtin-version isn't working well I'd recommend disabling it and then manually running it afterwards. |
3364dab
to
150c7bd
Compare
I have removed the code that updating There is no problem with wasm-opt-the-builtin-version, but an essential library (libbinaryen.dylib/libbinaryen.a) is not installed and linked. |
wasm_opt
, a dynamic library needs to be installed (for Linux and mac os). Update wasm-opt to version_97. #91 (comment)And the cache folder's structure will be as follow.
wasm_opt
version fromversion_97
toversion_105