Address Ruby dep issues and bump to v9.0.4
#211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: Bump rake-compiler from 1.2.1 to 1.2.5 Bump standard from 1.28.2 to 1.30.1 Bump rb_sys from 0.9.78 to 0.9.81 Bump rb-sys from 0.9.78 to 0.9.81 Bump wat from 1.0.64 to 1.0.69 Bump tokio from 1.28.1 to 1.29.1 Use a file to define nightly version Remove redundant `all` sub `cfg` directive chore: Pin nightly to 2023-04-23
ianks
changed the title
wasmtime to v0.9.4`wasmtime to v9.0.4
ianks
changed the title
wasmtime to v9.0.4v9.0.4
ext/Cargo.toml
Outdated
| wasmtime-wasi = "= 9.0.1" | ||
| wasi-common = "= 9.0.1" | ||
| wasi-cap-std-sync = "= 9.0.1" | ||
| # For ruby-head support, we have to lock to 0.5.4 until |
There was a problem hiding this comment.
Should this comment be updated to say 0.5.5?
ext/Cargo.toml
Outdated
| wat = "1.0.69" | ||
| tokio = { version = "1.28.2", features = ["rt", "rt-multi-thread", "time", "net"], optional = true } | ||
| async-timer = { version = "1.0.0-beta.8", features = ["tokio1"], optional = true } | ||
| wat = "1.0.63" |
There was a problem hiding this comment.
Any reason why we went back to 1.0.63?
There was a problem hiding this comment.
Git conflict resolution gone wrong, fixed now
ext/Cargo.toml
Outdated
| tokio = { version = "1.28.2", features = ["rt", "rt-multi-thread", "time", "net"], optional = true } | ||
| async-timer = { version = "1.0.0-beta.8", features = ["tokio1"], optional = true } | ||
| wat = "1.0.63" | ||
| tokio = { version = "1.28.1", features = [ |
There was a problem hiding this comment.
Same here, any reason why we went back to 1.28.1?
There was a problem hiding this comment.
Git conflict resolution gone wrong, fixed now
jbourassa
reviewed
Aug 22, 2023
ext/Cargo.toml
Outdated
Comment on lines
19
to
20
| # For ruby-head support, we have to lock to 0.5.4 until | ||
| # rb-sys/stable-api-compiled-fallback feature is used in Magnus. |
There was a problem hiding this comment.
Is this comment still accurate? The line below has 0.5.5, and IIUC 0.6.1 also has that?
|
Thanks Ian 🙇 |
jbourassa
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to issues surrounding ruby-head API stability, we've had to use a web of git forks to make things work with
ruby-head, which we continuously test in production. Now that oxidize-rb/rb-sys#227 is fixed and magnus v0.5.5 is released, we can untangle that.This PR does the following:
stable-apifeatureAfter this goes through, I will release a new gem version (v9.0.4).