Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Cargo.toml after lightbeam commit #96

Closed
moderation opened this issue Apr 6, 2019 · 4 comments
Closed

Missing Cargo.toml after lightbeam commit #96

moderation opened this issue Apr 6, 2019 · 4 comments

Comments

@moderation
Copy link

Since the introduction of Lightbeam with 9bf6d73 both cargo update and cargo build --release` result in the following error.

error: failed to read `/wasmtime/rust/wasmtime/lightbeam/Cargo.toml`

Caused by:
  No such file or directory (os error 2)
@moderation moderation changed the title Missing Cargo.toml after lightbeam PR Missing Cargo.toml after lightbeam commit Apr 6, 2019
@pepyakin
Copy link
Contributor

pepyakin commented Apr 6, 2019

Have you tried to update submodules?

@moderation
Copy link
Author

Thanks. git clone --recurse-submodules https://github.com/CraneStation/wasmtime.git worked. I'm pretty sure did a standard clone with git clone https://github.com/CraneStation/wasmtime.git prior to the lightbeam commit. Working now. Will see if there is a docs change I can make that might help.

@xuqzab
Copy link

xuqzab commented Apr 11, 2019

Readme needs to be updated to include using git clone --recurse-submodules https://github.com/CraneStation/wasmtime.git. Plain old git clone still doesn't work and no mention of correct command in readme.

@sunfishcode sunfishcode mentioned this issue Apr 11, 2019
Merged
@sunfishcode
Copy link
Member

I've now filed #103 to add this step to the README.

howjmay pushed a commit to howjmay/wasmtime that referenced this issue Jan 24, 2022
@alexcrichton
Implement support for memory64 (bytecodealliance#96)
92d338f 
* Implement support for memory64

Like the Rust crate this deletes the old `Limits` type in favor of
specific types/methods where relevant.

* Fix bazel build

* Remove `*.dll.a` file for windows
pchickey pushed a commit to pchickey/wasmtime that referenced this issue May 16, 2023
@sunfishcode
Allow preopen file descriptors to be closed. (bytecodealliance#96)
9915800 
* Allow preopen file descriptors to be closed.

This ports the test updates from bytecodealliance#5828 to the
preview2-prototype and implements the ability to close preopened file
descriptors.

* Fix compilation on Windows.
dhil added a commit to dhil/wasmtime that referenced this issue Feb 11, 2024
@dhil
Merge with upstream (bytecodealliance#96)
a47e06b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@moderation @pepyakin @sunfishcode @xuqzab