Fix a compiler warning. #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the following warning from Rust 1.35:
warning: cannot borrow `*self` as mutable because it is also borrowed as immutable
--> wasmtime-runtime/src/instance.rs:473:25
|
465 | } else if let Some(start_export) = self.module.exports.get("_start") {
| ----------- immutable borrow occurs here
...
473 | self.invoke_function(*func_index)
| ^^^^ ----------- immutable borrow later used here
| |
| mutable borrow occurs here
|
= note: #[warn(mutable_borrow_reservation_conflict)] on by default
= warning: this borrowing pattern was not meant to be accepted, and may become a hard error in the future
= note: for more information, see issue #59159 <rust-lang/rust#59159>
kubkon
approved these changes
May 30, 2019
mooori
added a commit
to mooori/wasmtime
that referenced
this pull request
Jan 5, 2024
perf: optimize zkASM for `CondBr` if target is a label
dhil
added a commit
to dhil/wasmtime
that referenced
this pull request
May 15, 2024
This patch modularises the optimized runtime in the same manner as the baseline runtime already was. It factors out the `StackChain` logic into a separate module `stack_chain`, which is needed to add support for backtraces to the baseline implementation (yet to be done!).
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Oct 23, 2024
…codealliance#168) Generate load/store specs using `AMode.UnsignedOffset`. Updates avanhatt#36 avanhatt#49 avanhatt#35
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Oct 23, 2024
…codealliance#168) Generate load/store specs using `AMode.UnsignedOffset`. Updates avanhatt#36 avanhatt#49 avanhatt#35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following warning from Rust 1.35: