Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some dead code from the abi code #4653

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented Aug 9, 2022

These were originally used by the old backend framework as part of legalizing function signatures for the respective ABI.

Found while working on #4634.

@bjorn3 bjorn3 force-pushed the cleanup_abi_param branch from f89e206 to f8f4690 Compare August 9, 2022 13:12
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:aarch64 Issues related to AArch64 backend. cranelift:area:x64 Issues related to x64 codegen cranelift:docs labels Aug 9, 2022
These were originally used by the old backend framework as part of
legalizing function signatures for the respective ABI.
@bjorn3 bjorn3 force-pushed the cleanup_abi_param branch from f8f4690 to b1a1e67 Compare August 9, 2022 13:26
@bjorn3
Copy link
Contributor Author

bjorn3 commented Aug 9, 2022

CI failure seems to be spurious.

Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cfallin cfallin merged commit a4aa725 into bytecodealliance:main Aug 9, 2022
@bjorn3 bjorn3 deleted the cleanup_abi_param branch August 9, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:area:aarch64 Issues related to AArch64 backend. cranelift:area:x64 Issues related to x64 codegen cranelift:docs cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants