Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c-api: add wasm_config_parallel_compilation_set #5298

Conversation

thibaultcha
Copy link
Contributor

This has not been discussed in issues and I do not believe there are tests cases for the config C API. Nevertheless, could we add this flag in the C API with this small changeset?

Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@alexcrichton alexcrichton enabled auto-merge (squash) November 18, 2022 20:04
@github-actions github-actions bot added the wasmtime:c-api Issues pertaining to the C API. label Nov 18, 2022
@github-actions
Copy link

Subscribe to Label Action

cc @peterhuene

This issue or pull request has been labeled: "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:c-api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

auto-merge was automatically disabled November 21, 2022 20:57

Head branch was pushed to by a user without write access

@thibaultcha thibaultcha force-pushed the feat/c-api-parallel-compilation branch from 3540142 to 16b4e10 Compare November 21, 2022 20:57
@github-actions github-actions bot added wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime labels Nov 21, 2022
@github-actions
Copy link

Subscribe to Label Action

cc @peterhuene

This issue or pull request has been labeled: "wasmtime:api", "wasmtime:config"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@github-actions
Copy link

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

  • If you added a new Config method, you wrote extensive documentation for
    it.

    Our documentation should be of the following form:

    Short, simple summary sentence.
    
    More details. These details can be multiple paragraphs. There should be
    information about not just the method, but its parameters and results as
    well.
    
    Is this method fallible? If so, when can it return an error?
    
    Can this method panic? If so, when does it panic?
    
    # Example
    
    Optional example here.
    
  • If you added a new Config method, or modified an existing one, you
    ensured that this configuration is exercised by the fuzz targets.

    For example, if you expose a new strategy for allocating the next instance
    slot inside the pooling allocator, you should ensure that at least one of our
    fuzz targets exercises that new strategy.

    Often, all that is required of you is to ensure that there is a knob for this
    configuration option in wasmtime_fuzzing::Config (or one
    of its nested structs).

    Rarely, this may require authoring a new fuzz target to specifically test this
    configuration. See our docs on fuzzing for more details.

  • If you are enabling a configuration option by default, make sure that it
    has been fuzzed for at least two weeks before turning it on by default.


To modify this label's message, edit the .github/label-messager/wasmtime-config.md file.

To add new label messages or remove existing label messages, edit the
.github/label-messager.json configuration file.

Learn more.

@thibaultcha
Copy link
Contributor Author

Can we restart the CI on this one? I don't think the failures are related; and we'd really like this being part of the next release if possible so that we don't lag too far behind the latest Wasmtime version...

@alexcrichton
Copy link
Member

Oh sorry missed the updates here, could you try rebasing? That known flaky test has been fixed on main

@thibaultcha thibaultcha force-pushed the feat/c-api-parallel-compilation branch from 16b4e10 to bbcf888 Compare November 29, 2022 22:16
@thibaultcha
Copy link
Contributor Author

Ah, excellent, done!

@alexcrichton alexcrichton enabled auto-merge (squash) November 29, 2022 22:19
@alexcrichton alexcrichton merged commit e7cb82a into bytecodealliance:main Nov 29, 2022
@thibaultcha thibaultcha deleted the feat/c-api-parallel-compilation branch November 29, 2022 23:03
@thibaultcha thibaultcha restored the feat/c-api-parallel-compilation branch August 3, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:c-api Issues pertaining to the C API. wasmtime:config Issues related to the configuration of Wasmtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants