Fix the build step #5664
Merged
Fix the build step #5664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottt
force-pushed
the
trevor/fix-build
branch
from
607c9c2 to
d76637e
Compare
elliottt
force-pushed
the
trevor/fix-build
branch
from
65b80aa to
42885bf
Compare
alexcrichton
approved these changes
Jan 31, 2023
elliottt
force-pushed
the
trevor/fix-build
branch
from
42885bf to
fe7cf2b
Compare
This reverts commit d76637e.
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Jan 31, 2023
This fixes the build issue identified in bytecodealliance#5664 at the toolchain level rather than working around it in our own build. The next step in fixing this will be to remove the nightly override in the future when the toolchain becomes stable.
alexcrichton
added a commit
that referenced
this pull request
Jan 31, 2023
This fixes the build issue identified in #5664 at the toolchain level rather than working around it in our own build. The next step in fixing this will be to remove the nightly override in the future when the toolchain becomes stable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the permissions on
libwasmtime.abefore copying it, to avoid errors stemming from new behavior in rustc-1.67. Mitigates the effects of rust-lang/rust#107495. See #5665.BuildworkflowBuildworkflow for PRs