wasi-common: deprecate fd_allocate #6217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subscribe to Label Actioncc @kubkon
This issue or pull request has been labeled: "wasi"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
pchickey
changed the title
alexcrichton
approved these changes
Apr 17, 2023
sunfishcode
reviewed
Apr 17, 2023
| // semantics on those two platforms. WASI never specified the semantics, and our test suite | ||
| // never included this operation. We have removed this operation from preview 2, and we are | ||
| // no longer supporting it in preview 1 as well. | ||
| Err(Error::not_supported()) |
There was a problem hiding this comment.
This is still removing support for fd_sync and fd_datasync, which I think we should keep. Even though they're not portable, there is value in being able to expose what functionality the host might have to applications.
There was a problem hiding this comment.
I got rid of that change locally but I didnt hit -f when I pushed it! Sorry.
added 2 commits
April 17, 2023 14:14
…TSUP This operation from cloudabi is linux-specific, isn't even supported across all linux filesystems, and has no support on macos or windows. Rather than ship spotty support, it has been removed from preview 2, and we are no longer supporting it in preview 1 as well. The preview 1 implementation will still check if fd is a file, and has rights, just to reject those cases with the errors expected.
rewrite the file_allocate test to just check for failure. remove use of fd_allocate from fd_advise test, and remove test configuration setting used for excluding use of fd_allocate on macos and windows.
pchickey
force-pushed
the
pch/deprecate_fd_sync_datasync_allocate
branch
from
4afa25a to
ccf347e
Compare
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes features from WASI Preview 1 that were supported inconsistently across platforms.
We are doing so because these features never worked on windows, and can't be supported consistiently on mac and linux. They have all been removed from the WASI Preview 2 spec in progress because of these inconsistencies.
We are not aware of any real-world programs or WASI users that are broken by removing this support.
fd_allocateThis operation from cloudabi is linux-specific, isn't even supported across all linux filesystems, and has no support on macos
or windows. Rather than ship spotty support, it has been removed from preview 2, and this PR removes support for it in preview 1 as well.
The PR also removes flags from the test suite which work around this operation only being available on linux.